Re: [Xen-devel] [PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to sysconfig.xencommons

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("[PATCH 1/5] tools/hotplug: move XENSTORED_MOUNT_CTX to 
sysconfig.xencommons"):
> On a non-SELinux system the mount option "context=none" works fine. But
> with SELinux enabled a proper value has to be defined. To simplify the
> required adjustment move XENSTORED_MOUNT_CTX from the service file to
> the sysconfig file.

This patch looks like just the hook.  It seems to be missing the part
where the actual selinux context is defined and plumbed through.


> There is no need to require the creation of a new sysconfig file, just
> reuse the existing /etc/sysconfig/xencommons file.

This seems to be an unrelated change ?  If not I confess I don't see
the connection.

> --- a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> +++ b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
...
>  [Mount]
> -Environment=XENSTORED_MOUNT_CTX=none
> -EnvironmentFile=-@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xenstored
> +EnvironmentFile=@CONFIG_DIR@/@CONFIG_LEAF_DIR@/xencommons

And won't this break existing systems which have an
/etc/{default,sysconfig}/xenstored ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel