Re: [Xen-devel] [PATCH] libxc: check in xc_get_tot_pages() that the proper domain is reported

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-12-02 at 13:43 -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 02, 2014 at 04:04:44PM +0000, Wei Liu wrote:
> > On Tue, Dec 02, 2014 at 04:18:08PM +0100, Vitaly Kuznetsov wrote:
> > > XEN_DOMCTL_getdomaininfo, which is being used by xc_domain_getinfo(), has
> > > strange interface: it reports first domain which has domid >= requested 
> > > domid
> > > so all callers are supposed to check that the proper domain(s) was queried
> > > by checking domid. xc_get_tot_pages() doesn't do that. In case the 
> > > requested
> > > domain was destroyed it will report first domain with domid > requested 
> > > domid
> > > which is apparently misleading as there is no way xc_get_tot_pages() 
> > > callers
> > > can figure out that they got tot_pages for some other domain.
> > > 
> > > Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> > 
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> Lets add another Ack to this party..
> 
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Applied, thanks.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel