Re: [Xen-devel] [PATCH for-4.5] systemd: use pkg-config to determine systemd library availability

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Dec 4, 2014 6:55 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
>
> On Wed, 2014-12-03 at 10:51 +0000, Ian Campbell wrote: 
> > On Wed, 2014-12-03 at 11:49 +0100, Olaf Hering wrote: 
> > > On Wed, Dec 03, Ian Campbell wrote: 
> > > 
> > > > Ah I didn't know about the sd_listen_fds thing, so I think that what we 
> > > > need then is to use pkg-config first to determine if systemd-daemon is 
> > > > present at all, and then check for specific symbols we require using 
> > > > the 
> > > > pkg-config supplied CFLAGS and LDFLAGS rather than assuming 
> > > > -lsystemd-daemon. 
> > > 
> > > Correction: sd_listen_fds is available since at least v1. 
> > >Â git describe --contains abbbea81a8fa70badb7a05e518d6b07c360fc09d 
> > >Â v1~390 
> > 
> > In that case I don't think we realistically need to check for it? 
>
> The implication here being that Wei's original patch is correct. Konrad, 
> do you think this is OK for the release? 
>
> > 

Yes. Release-Axked-By: Konrad Rzeszutek Wilk <Konrad.wilk@xxxxxxxxxx>
> > Ian. 
> > 
> > 
> > 
> > _______________________________________________ 
> > Xen-devel mailing list 
> > Xen-devel@xxxxxxxxxxxxx 
> > http://lists.xen.org/xen-devel 
>
>
>
> _______________________________________________ 
> Xen-devel mailing list 
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel