[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 4/9] xen: introduce XEN_DOMCTL_devour

On 03/12/2014 17:16, Vitaly Kuznetsov wrote:
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index a42d0b8..552e4a3 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -366,6 +366,8 @@ struct domain
      bool_t           is_privileged;
      /* Which guest this guest has privileges on */
      struct domain   *target;
+    /* Which guest receives freed memory pages */

It took me a while to understand that the recipient domain is a newly created domain, right? It might be worth to add a word here (and maybe in assign_pages).

With that in mind, the code in assign_pages makes more sense.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.