[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling



On 26/11/2014 19:03, Andrew Cooper wrote:
Strictly speaking Zheng, not being a maintainer, can't ack the patch,
given what I believe to be Xens current rules for these things.
However, as the author of the code and comment in this thread, his ack
can reasonably be considered equivalent to a  Reviewed-by:  I guess this
is just a matter of semantics.

Furthermore, as we all share an office, I have already been through this
process informally, and have confirmed the fix under my Xen-4.5 based
XenServer branch.  There appear to be 100% less "error -EINVAL" messages
in the logs.


Agreed. I was a bit confused by the "XXX-by" semantics. As Andy mentioned, he 
already went through the patch with me offline, so here is the line if more appropriate:

Reviewed-by: Zheng Li <dev@xxxxxxxx>

Thanks,
Zheng


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.