Re: [Xen-devel] [PATCH for 4.5] xl: Return proper error codes for block-attach and block-detach

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Wed, Nov 12, 2014 at 5:31 PM, George Dunlap
<george.dunlap@xxxxxxxxxxxxx> wrote:
> Return proper error codes on failure so that scripts can tell whether
> the command completed properly or not.

How about changing this to something like:

---
Return proper error codes on failure so that scripts can tell whether
the command completed properly or not.

This is not a proper fix, since it fails to call
libxl_device_disk_dispose() on the error path.  But a proper fix
requires some refactoring, so given where we are in the release
process, it's better to have a fix that is simple and obvious, and do
the refactoring once the next development window opens up.

Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
---

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel