[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Backport request for "tools/hotplug: set mtu from bridge for tap interface"

>>> On 11/18/2014 at 11:24 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote: 
> Daniel Kiper writes ("Re: [Xen-devel] delaying 4.4.2 and 4.3.4"):
>> By the way, what I should do to have commit 
> f3f5f1927f0d3aef9e3d2ce554dbfa0de73487d5
>> (tools/hotplug: set mtu from bridge for tap interface) in at least Xen 4.3?
>> I am asking about that more than five months. This patch fixes real bug.
> I don't seem to be able to find these mails from you but my mailbox is
> very big.  The normal thing ought to be for you to post a backport
> request and CC the stable tools maintainer (ie me).  I'm sorry if I
> dropped your message.
> The patch looks reasonable to backport.  I have put it on my list for
> backporting later.  I'll wait a bit to see if anyone objects.
> (I have also CC'd the patch's original author and also Ian C because
> he acked it for unstable.)

It should backport without problem.  I would also recommend this small
change that adds quotes around $bridge and $dev to handle spaces in names.
This should also go into unstable.

diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge
index 3d72ca4..8b67b0a 100644
--- a/tools/hotplug/Linux/vif-bridge
+++ b/tools/hotplug/Linux/vif-bridge
@@ -77,7 +77,7 @@ fi
 case "$command" in
         setup_virtual_bridge_port "$dev"
-        set_mtu $bridge $dev
+        set_mtu "$bridge" "$dev"
         add_to_bridge "$bridge" "$dev"
@@ -88,7 +88,7 @@ case "$command" in
         setup_virtual_bridge_port "$dev"
-        set_mtu $bridge $dev
+        set_mtu "$bridge" "$dev"
         add_to_bridge "$bridge" "$dev"

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.