Re: [Xen-devel] [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

["Dugger, Donald D" <donald.d.dugger@xxxxxxxxx>]

Hmm, good ideas.  How about I change the `snb_igd_quirk' parameter to be:

                snb_igd_quirk                 => current behavior, enable quirk 
with 1 sec timeout
                snb_igd_quirk=default  => enable quirk with theoretical max 
timeout of 670 msec
                snb_igd_quirk=n             => enable quirk with timeout of `n' 
msec

--
Don Dugger
"Censeo Toto nos in Kansa esse decisse." - D. Gale
Ph: 303/443-3786

-----Original Message-----
From: Jan Beulich [mailto:JBeulich@xxxxxxxx] 
Sent: Monday, November 17, 2014 5:07 AM
To: Dugger, Donald D
Cc: Kay, Allen M; Dong, Eddie; Auld, Will; xen-devel@xxxxxxxxxxxxx
Subject: Re: [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

>>> On 17.11.14 at 05:11, <donald.d.dugger@xxxxxxxxx> wrote:
> @@ -237,6 +254,18 @@
>      }
>  }
>  
> +static void __init parse_snb_timeout(const char *s) {
> +
> +     if (*s == '\0')
> +             snb_igd_timeout = SNB_IGD_TIMEOUT;
> +     else
> +             snb_igd_timeout = MILLISECS(simple_strtoul(s, &s, 0));
> +     snb_igd_quirk = 1;
> +     return;
> +}
> +custom_param("snb_igd_timeout", parse_snb_timeout);

Rather than adding a new command line option, can't you simply re-use (by 
extending) the existing (boolean) one? And similarly replace the current 
variable (using a value of zero to indicate no
quirk) rather than adding another one?

Also note that the if() statement above needs spaces inserted to match our 
coding style.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel