Re: [Xen-devel] [PATCH] fix rename: xenstore not fully updated

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-11-17 at 10:48 +0000, Wei Liu wrote:
> On Mon, Nov 17, 2014 at 10:42:45AM +0000, Ian Campbell wrote:
> > On Mon, 2014-11-17 at 10:41 +0000, Wei Liu wrote:
> > > On Mon, Nov 17, 2014 at 10:25:31AM +0000, Ian Campbell wrote:
> > > > On Mon, 2014-11-17 at 09:52 +0000, Wei Liu wrote:
> > > > > > +    /* update backend 
> > > > > > /local/domain/0/backend/<device>/<domid>/.../domain */
> > > > > > +    be_dev = libxl__xs_directory(gc, trans, 
> > > > > > "/local/domain/0/backend", &ndevs);
> > > > > 
> > > > > The hard-coded 0 cannot work if you have driver domain.
> > > > > 
> > > > > At the very least it should be using LIBXL_TOOLSTACK_DOMID.
> > > > 
> > > > Does anyone know the purpose of this node, i.e. what consumes it?
> > > > docs/misc/xenstore-paths.markdown doesn't mention it, neither do any of
> > > > xen/include/public/io/*.h AFAICS.
> > > > 
> > > > The backend needing to know the name (as opposed to domid) of the
> > > > frontend domain seems rather unusual to me.
> > > > 
> > > 
> > > I think it's for consistency but Chunyan might have different opinions.
> > 
> > Consistency of what?
> > 
> 
> Say, when you look at backend path, it shows the frontend domain has
> name of "blah--incoming" because it's migrated; however, in
> /local/domain/$DOMID/ there's a different name "blah".

I'm suggesting we nuke this key entirely because it is meaningless, not
questioning the need for it to be correct if we keep it.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel