Re: [Xen-devel] [PATCH for-xen-4.5] tools/hotplug: use configure --sysconfdir result

[Olaf Hering <olaf@xxxxxxxxx>]

On Wed, Nov 12, Konrad Rzeszutek Wilk wrote:

> On Wed, Nov 12, 2014 at 06:06:57PM +0100, Olaf Hering wrote:
> > On Wed, Nov 12, Konrad Rzeszutek Wilk wrote:
> > 
> >  
> > > What happens if we do not take that in now but delay to Xen 4.6?
> > 
> > I will be very unhappy...
> > I mean, what exactly is the concern here?!
> 
> I need to know what the risk is if this does not go in. We
> are at RC2 and I really want to make the amount of patches
> that go in be a trickle.

Its risk free.

> > > Will systemd still correctly work? It looks like it will and 
> > > this is just an improvement that makes the code be more streamlined.
> > > 
> > > It does not fix a bug (at least that is what I see from
> > > reading), I believe this should be deferred to Xen 4.6.
> > 
> > It does fix a bug. If the whole thing was configured with --prefix=X
> > --sysconfdir=Y parts of it will still refer to hardcoded paths entirely
> > unrelated to what was just installed with 'make install'.
> 
> How often does that happen? Do the two paths that are specified
> in the code cover 99% of the use-cases?

It covers 100% of the use cases. Just today someone complained on
xen-users that stuff isnt appearing below /usr/local (not sure why, not
our fault), but even if it was there it wouldnt be used because the code
hardcodes /etc.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel