Re: [Xen-devel] [PATCH for-4.5] libxl: add missing action in DEFINE_DEVICE_ADD

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Nov 12, 2014 at 10:01:24AM +0000, Ian Campbell wrote:
> On Tue, 2014-11-11 at 13:46 +0000, Wei Liu wrote:
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> > Cc: Konrad Wilk <konrad.wilk@xxxxxxxxxx>
> > ---
> > This is a simple enough bug fix I think it should just go in.
> 
> Probably, but can you explain in the commit log what the symptoms of not
> doing it are, IOW why it is required.
> 

OK, I will resubmit with updated commit log.

> > ---
> >  tools/libxl/libxl.c |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index f7961f6..de23fec 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -4164,6 +4164,7 @@ DEFINE_DEVICE_REMOVE(vtpm, destroy, 1)
> >                                                                          \
> >          GCNEW(aodev);                                                   \
> >          libxl__prepare_ao_device(ao, aodev);                            \
> > +        aodev->action = LIBXL__DEVICE_ACTION_ADD;                       \
> >          aodev->callback = device_addrm_aocomplete;                      \
> >          aodev->update_json = true;                                      \
> >          libxl__device_##type##_add(egc, domid, type, aodev);            \
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel