[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Wrong cpupool handling


  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: Dietmar Hahn <dietmar.hahn@xxxxxxxxxxxxxx>
  • Date: Tue, 11 Nov 2014 13:18:48 +0100
  • Cc: jgross@xxxxxxxx
  • Delivery-date: Tue, 11 Nov 2014 12:19:09 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:From:To:Cc:Subject:Date:Message-ID: User-Agent:MIME-Version:Content-Transfer-Encoding: Content-Type; b=hBH9ksWnXEchVC7Dr8A2v2E7msNf50QBYOBVBRnjMlmp97IdlGGaGDuU 2nvqH1Wm+ybgLSJJEwPIX1seHCltrAtReULNdT5kWsDKPxg1Da9WsVE2p mhLjW069d/h5ErUEESpQNHjo8r7itShMA69a+20beMlw+YFzCdNHGaB6u wx8vduJvoUtTMP7Ea0B596iaILhAkp5+9NqTC9fmqkLi9JNTjWt1Tk8gQ +VJwkkpVvAzIHGY2t0VCP//pRBlHM;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

Hi list,

When creating a cpupool, starting and destroying a guest within this pool,
then removing this pool doesn't work because of EBUSY.

It seems the cause of this behavior is the commit
bac6334b51d9bcfe57ecf4a4cb5288348fcf044a.

In domain_kill() the function sched_move_domain() gets called changing the
d->cpupool pointer to the new cpupool without incrementing/decrementing the
counters "n_dom" of the new/old cpupool.

This leads to decrementing the wrong  cpupool0->n_dom counter when
cpupool_rm_domain() gets called at the end and my own cpupool can't be
destroyed because n_dom = 1!

I don't have a fast patch because I'am not enough familiar with the code
this time but I think it should be fixed for 4.5.

Dietmar.


-- 
Company details: http://ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.