[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 for 4.5] xen/arm: Add support for GICv3 for domU

>>> On 06.11.14 at 10:45, <julien.grall@xxxxxxxxxx> wrote:
> Hi Jan,
> On 05/11/2014 17:15, Jan Beulich wrote:
>>>>> Julien Grall <julien.grall@xxxxxxxxxx> 11/04/14 6:27 PM >>>
>>> On 11/03/2014 04:39 PM, Konrad Rzeszutek Wilk wrote:
>>>> It also needs Acks from Daniel and Jan.
>>> This patch doesn't modify the x86 part. So I'm not sure if Jan ack is
>>> required. Would Ian C. ack be enough?
>> Yes, it would.
>>> Anyway, Jan do you have any objection on this patch?
>> As said previously, I'm not particularly happy about it, but I also don't 
> strongly
>> mind it going in in the current shape.
> May I ask what is wrong with the new approach to the a DOMCTL in this patch?
> The DOMCTL has been clearly identify as arm specific (there is "arm" in 
> the name). Therefore it doesn't seem necessary to expose it for other 
> architecture than ARM32 and ARM64.

I didn't say there's anything actively wrong with it, all I said is that
I'm not particularly happy about it: Irrespective of its name it doesn't
look to be really arch-specific in the long run, plus it feels like the
data being set here should rather be specified right at domain
creation, or via a mechanism similar to x86'es HVM parameters (iirc
the value set here can't be changed once the domain got first


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.