Re: [Xen-devel] [PATCH] tools/hvmloader: link errno.h from xen internal

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.10.14 at 03:18, <tiejun.chen@xxxxxxxxx> wrote:

(You omitted half of the tools maintainers; Cc-ing them now.)

> We will use some error numbers in hvmloader so here just link
> this head file from xen.

This is not a proper reasoning for using the Xen internal header here.
You should make clear that we want to act on specific hypercall
error codes, and hence require the hypervisors view on the errno.h
values rather than the build environment's (as was sufficient for the
use in xenbus.c).

> --- a/tools/firmware/hvmloader/Makefile
> +++ b/tools/firmware/hvmloader/Makefile
> @@ -84,9 +84,13 @@ ROMS += $(SEABIOS_ROM)
>  endif
>  
>  .PHONY: all
> -all: subdirs-all
> +all: subdirs-all .dir
>       $(MAKE) hvmloader
>  
> +.dir:
> +     @rm -rf errno.h

Why?

> --- a/tools/firmware/hvmloader/util.h
> +++ b/tools/firmware/hvmloader/util.h
> @@ -6,6 +6,7 @@
>  #include <stddef.h>
>  #include <xen/xen.h>
>  #include <xen/hvm/hvm_info_table.h>
> +#include "errno.h"

Does this allow xenbus.c to still build? I think this either should go into
the .c file wanting to use the values (preferable - remember my earlier
comment about introducing unnecessary dependencies?), or the
respective #include <errno.h> in xenbus.c should be dropped.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel