Re: [Xen-devel] [RFC PATCH v2 09/11] time: Convert pvclock_read_wallclock() to use timespec64

[Thomas Gleixner <tglx@xxxxxxxxxxxxx>]

On Thu, 30 Oct 2014, pang.xunlei wrote:
>       /* get wallclock at system boot */
>       do {
>               version = wall_clock->version;
>               rmb();          /* fetch version before time */
> -             now.tv_sec  = wall_clock->sec;
> +             /* TODO: [2038 safety] wall_clock->sec uses time64_t */

Wrong. This is part of the hypervisor ABI and you can add as many
TODOs here as you want. They will not change the ABI ever. If XEN
wants to fix that it needs to implement a new hypervisor interface.

> +             now.tv_sec  = (time64_t)wall_clock->sec;

copy & paste does not solve all these problems magically.

Thanks,

        tglx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel