Re: [Xen-devel] [PATCH 2/6] vTPM: add HVM_PARAM_STUBDOM_VTPM parameter for HVM virtual machine

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 30/10/14 07:38, Quan Xu wrote:
> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>

What is the purpose of this parameter?  A patch like this is currently
unacceptable, especially as the libxl hunk indicates that the parameter
name does not match whatever information you are putting into it.

> ---
>  tools/libxl/libxl_dom.c         | 2 ++
>  xen/arch/x86/hvm/hvm.c          | 3 +++
>  xen/include/public/hvm/params.h | 1 +
>  3 files changed, 6 insertions(+)
>
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 74ea84b..a60e8c9 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -291,6 +291,8 @@ static void hvm_set_conf_params(xc_interface *handle, 
> uint32_t domid,
>  #if defined(__i386__) || defined(__x86_64__)
>      xc_hvm_param_set(handle, domid, HVM_PARAM_HPET_ENABLED,
>                      libxl_defbool_val(info->u.hvm.hpet));
> +    xc_set_hvm_param(handle, domid, HVM_PARAM_STUBDOM_VTPM,
> +                     info->num_vtpms);
>  #endif
>      xc_hvm_param_set(handle, domid, HVM_PARAM_TIMER_MODE, timer_mode(info));
>      xc_hvm_param_set(handle, domid, HVM_PARAM_VPT_ALIGN,
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index 78f519d..39e4c11 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -5696,6 +5696,9 @@ long do_hvm_op(unsigned long op, 
> XEN_GUEST_HANDLE_PARAM(void) arg)
>  
>                  break;
>              }
> +            case HVM_PARAM_STUBDOM_VTPM:
> +                rc = 0;
> +                break;
>              }
>  
>              if ( rc == 0 ) 
> diff --git a/xen/include/public/hvm/params.h b/xen/include/public/hvm/params.h
> index 3c51072..333c131 100644
> --- a/xen/include/public/hvm/params.h
> +++ b/xen/include/public/hvm/params.h
> @@ -56,6 +56,7 @@
>  
>  #if defined(__i386__) || defined(__x86_64__)
>  
> +#define HVM_PARAM_STUBDOM_VTPM 8

New params should be added to the end of the number range.  8 is not up
for grabs.

~Andrew

>  /*
>   * Viridian enlightenments
>   *


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel