Re: [Xen-devel] [PATCH V2 for-4.5] EFI: Always use EFI command line

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-10-30 at 09:49 +0000, Jan Beulich wrote:
> >>> On 30.10.14 at 03:21, <roy.franz@xxxxxxxxxx> wrote:
> > So the open question is, when booted from GRUB (or other bootloader),
> > should Xen get it's commandline via the EFI
> > commandline, or via the MB2 protocol?  (and for arm64, this means the
> > FDT based multiboot.)  I felt that the shared code
> > in GRUB was a reasonable reason to follow what Linux did in the EFI case.

Isn't the "unshared" code here an if statement (or maybe two)? I don't
see why this one difference would require a troublesome amount of
separation the implementations.

> Consistency would call for MB2/FDT, but in the end this can very well
> be arch-specific imo (but in that case the patch also needs to reflect
> this).

I don't have a strong opinion either way, but if it is to change for
arm64 I'd like to see a proposed update to
http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot
as a starting point for deciding.

It needs to be careful not to break the "multiboot as a series of u-boot
fdt commands" case too.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel