Re: [Xen-devel] [PATCH OSSTEST v2 09/20] make-flight: Run a basic test on each arm platform

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 09/20] make-flight: Run a basic test on 
each arm platform"):
> Unlike x86 there is enough variation in the ARM platforms that it is worth
> having a basic test on each as part of a standard run. This relies on each 
> host
> having an appropriate platform-$platform host flag.
> 
> The existing test-ARCH-ARCH-xl test is retained as a floating test, while a 
> new
> variant is added for each distinct platform present in the hostdb which is 
> tied
> to that platform type. The intention is that only arm platforms will have
> platforms at first, although perhaps platform-intel and platform-amd could be
> added in the future too.

The sql looks good.

> +sub get_arch_platforms ($$) {
> +    my ($hd, $blessing, $arch) = @_;
> +
> +    my $prop = "Platforms".ucfirst($arch);
> +
> +    return split /[, ]/, $c{$prop} if $c{$prop};

I think you probably want   split /[, \t]+/   or maybe  split /\s+/

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel