[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Sanity check input and serialize vcpu data in sched_rt.c

On Sat, 2014-10-25 at 10:16 -0400, Meng Xu wrote:
> These two patches are to solve the issues found by Jan Beulich at 
> http://lists.xen.org/archives/html/xen-devel/2014-09/msg03554.html.
> The solution is summarized by Dario Faggioli at 
> http://lists.xen.org/archives/html/xen-devel/2014-09/msg03603.html.
> Here is the solution:
>      - sanity checking input params in rt_dom_cntl()
>      - serialize rt_dom_cntl() itself against the global lock
>      - move the call to rt_update_deadline() from _alloc to _insert
Ok, thanks Meng for the patches, and for this summary.

I've already reviewed the patches, and they look fine to me. If I can
add a few things about the submission:
 - threading is ok this time, good job with that :-D
 - cover letter subject summarizes properly the series content, but 
   should contain the [PATCH xxx xxx] prefix as regular patches, as if
   it were patch 0 of the series
 - since this is v2, it is really useful to include, in each patch, a
   quick summary of what changed wrt previous version. You usually do it
   in the changelog of each patch itself, after a "---" mark, below the
   Signed-off and similar tags

Finally, since we're in freeze, we should 'convince' Konrad that these
patches really need to be merged right now, instead of waiting for 4.6.

See Konrad's development update emails for more details. About that,
Konrad, my take is as follows:
 - this is a bugfix, so, always a good one to have :-)
 - this only touches the new scheduler's code, with basically zero
   chances of causing issues to others
 - the new scheduler is marked as experimental

So, yes, I think these patches should be considered for 4.5


<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.