[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/vtd: cleanup some comments



On 2014/10/24 18:33, Jan Beulich wrote:
On 24.10.14 at 04:50, <tiejun.chen@xxxxxxxxx> wrote:
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct 
domain *d)

      if ( !iommu_passthrough && !need_iommu(d) )
      {
-        /* Set up 1:1 page table for dom0 */
+        /* Set up 1:1 page table for hardware domain */
          vtd_set_hwdom_mapping(d);
      }

@@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
      if ( iommu_use_hap_pt(d) )
          return 0;

-    /* do nothing if dom0 and iommu supports pass thru */
+    /* do nothing if hardware domain and iommu supports pass thru */

If you clean up comments, please make them match ./CODING_STYLE.

Sorry, could you say this explicitly?

From my point of view, this is just one line and this line is already less than 80 characters in length. Or just add a period at the end of the sentence?

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.