[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V2 for-4.5] EFI: Always use EFI command line

On 10/25/2014 05:27 PM, Fu Wei wrote:
> On 10/25/2014 05:06 PM, Ian Campbell wrote:
>> On Fri, 2014-10-24 at 16:41 -0700, Roy Franz wrote:
>>>   (I'm not sure how I'm supposed to refer to to docs/misc/efi.markdown in
>>>    the booting.txt.  Should I assume that it will be processed to html
>>>    and refrence it that way?)
>> This stuff kinda sucks because it all depends on where you build and
>> install to etc. What you've done in naming the file as it appears in the
>> source is fine. Other places use a reference to the canonical online
>> copy at http://xenbits.xen.org/docs/unstable/ which is fine too I think.
>>> @@ -104,4 +106,6 @@ and really not meant to be used together with the 
>>> `-cfg=` command line option.
>>>  Filenames must be specified relative to the location of the EFI binary.
>>>  Extra options to be passed to Xen can also be specified on the command 
>>> line,
>>> -following a `--` separator option.
>>> +following a `--` separator option.
>> Will grub automatically insert this "--" marker? Or is there some
>> special handling in Xen when none of -cfg/-help/-videothing are present?
>> (Doesn't look to be the case)
> For now, I didn't make this automatically "--" injection.
> Do we need to do this, or just let user do it by themselves?
> In my opinion, according to the wiki page, we should make the injection?
> http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot
> any thought and suggestion?? :-)

I have made a patch for this:
If the first argument is not "--", grub will add "--" as first argument.

But I don't think it is a good fix.

So please let me know what is your decision, then I can make the multiboot 
behavior right :-)
before I get your info, my multiboot patch won't take care of "--"

>> Ian.

Best regards,

Fu Wei
Software Engineer From Red Hat
LEG Team
Linaro.org | Open source software for ARM SoCs
Ph: +86 186 2020 4684 (mobile)
IRC: fuwei
Skype: tekkamanninja
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021 

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.