Re: [Xen-devel] [PATCH v2 08/47] kernel: Move pm_power_off to common code

[James Hogan <james.hogan@xxxxxxxxxx>]

Hi Guenter,

On 21/10/14 05:12, Guenter Roeck wrote:
> pm_power_off is defined for all architectures. Move it to common code.
> 
> Have all architectures call do_kernel_power_off instead of pm_power_off.
> Some architectures point pm_power_off to machine_power_off. For those,
> call do_kernel_power_off from machine_power_off instead.
> 
> Acked-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Acked-by: Hirokazu Takata <takata@xxxxxxxxxxxxxx>
> Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>
> Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
> Acked-by: Rafael J. Wysocki <rjw@xxxxxxxxxxxxx>
> Acked-by: Richard Weinberger <richard@xxxxxx>
> Acked-by: Xuetao Guan <gxt@xxxxxxxxxxxxxxx>

For metag:
Acked-by: James Hogan <james.hogan@xxxxxxxxxx>

Thanks
James

> diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
> index 483dff9..8d95773 100644
> --- a/arch/metag/kernel/process.c
> +++ b/arch/metag/kernel/process.c
> @@ -67,9 +67,6 @@ void arch_cpu_idle_dead(void)
>  }
>  #endif
>  
> -void (*pm_power_off)(void);
> -EXPORT_SYMBOL(pm_power_off);
> -
>  void (*soc_restart)(char *cmd);
>  void (*soc_halt)(void);
>  
> @@ -90,8 +87,7 @@ void machine_halt(void)
>  
>  void machine_power_off(void)
>  {
> -     if (pm_power_off)
> -             pm_power_off();
> +     do_kernel_power_off();
>       smp_send_stop();
>       hard_processor_halt(HALT_OK);
>  }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel