Re: [Xen-devel] [PATCH for-xen-4-5 v3] xen/arm: dump guest stack even if not the current VCPU

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 10/23/2014 12:31 PM, Ian Campbell wrote:
> On Thu, 2014-10-23 at 09:46 +0100, Frediano Ziglio wrote:
>> From: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
>>
>> If show_guest_stack was called from Xen context (for instance hitting
>> '0' key on Xen console) get_page_from_gva was not able to get the
>> page returning NULL.
>> Detecting different domain and changing VTTBR register make
>> get_page_from_gva works for different domains.
>>
>> Signed-off-by: Frediano Ziglio <frediano.ziglio@xxxxxxxxxx>
> 
> Acked + applied (since Konrad said ok in v2).
> 
>> - collapse change in a single if to improve performances.
> 
> Not 100% keen on the duplicated call to gvirt_to_maddr, but it'll do.

I think having two if with gvirt_to_maddr in the middle would have been
fine. My main concern was disabling the IRQ before taking the lock.

Anyway, I plan to send a patch for 4.6 to improve this function. The p2m
is taken for a long time for nothing.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel