[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xen/balloon: Don't continue ballooning when BP_ECANCELED is encountered



On 09.10.2014 19:17, David Vrabel wrote:
> On 07/10/14 22:00, Boris Ostrovsky wrote:
>> Commit 3dcf63677d4e ("xen/balloon: cancel ballooning if adding new
>> memory failed") makes reserve_additional_memory() return BP_ECANCELED
>> when an error is encountered. This error, however, is ignored by the
>> caller (balloon_process()) since it is overwritten by subsequent call
>> to update_schedule(). This results in continuous attempts to add more
>> memory, all of which are likely to fail again.
>>
>> We should stop trying to schedule next iteration of ballooning when
>> the current one has failed.
> 
> What triggers this bug?  I could never work out what it was.
> 
> Applied to stable/for-linus-3.18

I just checked in the kernel upstream repo and cannot find this but I believe
the initial pull was already made. Or was there a revert that I missed?

-Stefan

> 
> David
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 


Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.