Re: [Xen-devel] [PATCH v5] Sanity check xsave area when migrating or restoring from older Xen verions

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.10.14 at 15:59, <dkoch@xxxxxxxxxxx> wrote:
> @@ -2039,10 +2033,22 @@ static int hvm_load_cpu_xsave_states(struct domain 
> *d, hvm_domain_context_t *h)
>      if ( desc->length > size )
>      {
>          printk(XENLOG_G_WARNING
> -               "HVM%d.%d restore mismatch: xsave length %u > %u\n",
> +               "HVM%d.%u restore mismatch: xsave length %#x > %#x\n",
>                 d->domain_id, vcpuid, desc->length, size);
> -        return -EOPNOTSUPP;
> +        /*
> +         * Xen-4.3 and older used to send longer-than-needed xsave regions. 
> +         * Permit loading the record if the extra data is all zero.
> +         */
> +       for ( i = size; i < desc->length; i++ )
> +        {
> +            if ( h->data[overflow_start + i] )
> +            {
> +                printk(XENLOG_G_WARNING
> +                       "HVM%d.%u restore mismatch: xsave has non-zero data 
> starting at %#x\n",
> +                       d->domain_id, vcpuid, i);
> +                return -EOPNOTSUPP;
> +            }
> +        }
>      }
>      /* Checking finished */
>  

See the reply on v4 just sent - these are _still_ two messages in
certain cases.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel