Re: [Xen-devel] [PATCH for 4.5 v7 1/1] Add mmio_hole_size

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-10-21 at 08:46 +0100, Jan Beulich wrote:
> >>> On 21.10.14 at 00:01, <dslutz@xxxxxxxxxxx> wrote:
> > On 10/20/14 10:17, Ian Campbell wrote:
> >> On Mon, 2014-10-13 at 08:51 -0400, Don Slutz wrote:
> >>> --- a/tools/libxl/libxl_types.idl
> >>> +++ b/tools/libxl/libxl_types.idl
> >>> @@ -391,6 +391,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
> >>>                                          ("timeoffset",       string),
> >>>                                          ("hpet",             
> >>> libxl_defbool),
> >>>                                          ("vpt_align",        
> >>> libxl_defbool),
> >>> +                                       ("mmio_hole_size",   uint64),
> >> Please make this a MemKB at the libxl interface level and convert
> >> internally to whatever hvmloader expects. It seems that a more
> >> conventional name would also have a _memkb suffix. Perhaps
> >> mmio_hole_memkb? (size seems to be implicit to me).
> >>
> > 
> > Ok, Jan Beulich had proposed the name with the _size (on 27 Jun 2014), 
> > but he
> > did also say "(whether the xl config option should also get renamed I'm not
> > sure - the xl maintainers will know )", (so I am taking this as ok from 
> > Jan) I will
> > rename to mmio_hole_memkb here.
> 
> My remark was really intended for you to actively inquire about the
> config option name.

Or better yet, look at the existing examples for both libxl API and xl
configuration file names and if you aren't sure then ask.

foo_memkb is conventional in the libxl interface. For the xl.cfg level
the units are typically mbytes and the names unitless (i.e. no _memkb
suffix), often due to xm legacy. The existing xl.cfg names are things
like "memory", "maxmem", "shadow_memory", "videoram". I think mmio_hole
or mmio_hole_size would be a good enough name for xl.cfg.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel