Re: [Xen-devel] [PATCH v5 for 4.5] arm32: fix build after 063188f4b3

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-10-20 at 11:52 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 10/20/2014 11:49 AM, Ian Campbell wrote:
> > On Thu, 2014-10-16 at 13:34 +0100, Julien Grall wrote:
> >> "xen: arm: Add support for the Exynos secure firmware" introduced code
> >> assuming that exynos_smc() would get called with arguments in certain
> >> registers. While the "noinline" attribute guarantees the function to
> >> not get inlined, it does not guarantee that all arguments arrive in the
> >> assumed registers: gcc's interprocedural analysis can result in clone
> >> functions to be created where some of the incoming arguments (commonly
> >> when they have constant values) get replaced by putting in place the
> >> respective values inside the clone.
> >>
> >> Xen contains in multiple place of this SMC function: consolidate the 
> >> function
> >> in a single place and write it in assembly.
> >>
> >> Reported-by: Jan Beulich <jbeulich@xxxxxxxx>
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > I think a better $subject would be "xen: arm: introduce assembly helper
> > to call smc" and to begin the body with:
> >         Commit 063188f4b3 "xen: arm: Add support for..."
> > 
> > If that's OK with you I'll make that change as I commit.
> 
> I fine with it.

Done. thanks.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel