Re: [Xen-devel] [OPW PATCH V3] tools/xl: Call init function for libxl defined datatypes

[Uma Sharma <uma.sharma523@xxxxxxxxx>]

Actually I looked at the patch sending documentation it stated that if
some changes are already acknowledged then we have to write it.
Should I write a new patch with all these changes ? Or I can make the
changes in different patches?

Regards,
Uma Sharma

On Sun, Oct 19, 2014 at 6:25 PM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> On Sun, Oct 19, 2014 at 06:05:01PM +0530, Uma Sharma wrote:
>> This patch calls init function for libxl_domain_sched_params before
>> passing it as reference to sched_domain_get() function in
>> tools/libxl/xl_cmdimpl.c
>> IDL generated libxl types should be used only after calling the init
>> function even if the variable is simply being passed by reference as
>> an output parameter to a libxl function
>>
>> Signed-off-by: Uma Sharma <uma.sharma523@xxxxxxxxx>
>> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>
> It's confusing that you sent this v3 patch with my ack on it while at
> the same time changed a bunch of other places.
>
> If you have other places to fix, you can send separate patch(es) to fix
> them. If you want to squash these changes into one patch, then please
> drop my ack (not that I'm against these changes, just that you've
> substantially changed the scope of this patch we agreed upon) and write
> proper change log.
>
> Hope the above clarification help you understand the process better, and
> please don't hesitate to ask any question.
>
> Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel