Re: [Xen-devel] [PATCH for-xen-4.5 v4 02/18] x86/boot: fix reloc.S build dependencies

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Fri, Oct 17, 2014 at 03:51:35PM +0100, Jan Beulich wrote:
> >>> On 17.10.14 at 16:11, <daniel.kiper@xxxxxxxxxx> wrote:
> > --- a/xen/arch/x86/boot/Makefile
> > +++ b/xen/arch/x86/boot/Makefile
> > @@ -1,8 +1,12 @@
> >  obj-bin-y += head.o
> >
> > +RELOC_DEPS = $(BASEDIR)/include/asm-x86/config.h 
> > $(BASEDIR)/include/xen/multiboot.h
> > +
> > +export RELOC_DEPS
>
> This can be done on one line, but I'd prefer dropping the export
> altogether and communicating the setting on just the make
> invocation line.

I suppose that you think about that one:

%.S: %.c
         $(MAKE) -f build32.mk $@ RELOC_DEPS=$(RELOC_DEPS)

However, this is a bit strange because in general rule
we pass args for specific build. So, maybe we should
do that:

reloc.S: reloc.c $(RELOC_DEPS)
         $(MAKE) -f build32.mk $@ RELOC_DEPS=$(RELOC_DEPS)

and simply remove this generic rule from Makefile.

> > -reloc.S: head.S
> > +reloc.S: $(RELOC_DEPS)
>
> The dropping of the head.S dependency seems fine, but needs to be
> briefly explained in the commit message.

OK.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel