Re: [Xen-devel] [PATCH for-xen-4.5 v4 00/18] xen: Break multiboot (v1) dependency and add multiboot2 support

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Fri, Oct 17, 2014 at 03:42:38PM +0100, Jan Beulich wrote:
> >>> On 17.10.14 at 16:11, <daniel.kiper@xxxxxxxxxx> wrote:
> > This is my last attempt to have this series in 4.5. If it will be not
> > accepted for 4.5 I will continue multiboot2 + EFI development on the
> > base of this patch series. Now I am almost sure that we are going in
> > right direction. I hope that I will be able to post multiboot2 + EFI
> > patches in about 1 month.
>
> Simply looking at the diffstat:
>
> >  xen/Makefile                      |    2 +-
> >  xen/arch/x86/Makefile             |    1 +
> >  xen/arch/x86/boot/Makefile        |    8 +-
> >  xen/arch/x86/boot/build32.mk      |    3 +-
> >  xen/arch/x86/boot/cmdline.S       |    9 +-
> >  xen/arch/x86/boot/head.S          |  157 
> > ++++++++++++++++++++++++++++++-----
> >  xen/arch/x86/boot/reloc.c         |  223
> > ++++++++++++++++++++++++++++++++++++++++---------
> >  xen/arch/x86/boot/x86_64.S        |   10 ++-
> >  xen/arch/x86/boot_info.c          |  257
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  xen/arch/x86/dmi_scan.c           |   11 ++-
> >  xen/arch/x86/domain_build.c       |   24 +++---
> >  xen/arch/x86/efi/efi-boot.h       |  173 
> > +++++++++++++++++++-------------------
> >  xen/arch/x86/microcode.c          |   39 ++++-----
> >  xen/arch/x86/mpparse.c            |   13 ++-
> >  xen/arch/x86/platform_hypercall.c |   17 ++--
> >  xen/arch/x86/setup.c              |  369 
> > +++++++++++++++++++++++++++-------------------------------------------------------
> >  xen/arch/x86/x86_64/asm-offsets.c |   15 +++-
> >  xen/common/efi/boot.c             |    1 -
> >  xen/common/efi/efi.h              |   11 +++
> >  xen/common/efi/runtime.c          |   55 +++++++++++--
> >  xen/drivers/acpi/osl.c            |   13 ++-
> >  xen/drivers/video/vesa.c          |    7 +-
> >  xen/drivers/video/vga.c           |   18 ++--
> >  xen/include/asm-x86/boot_info.h   |  124 ++++++++++++++++++++++++++++
> >  xen/include/asm-x86/config.h      |    2 -
> >  xen/include/asm-x86/e820.h        |    8 --
> >  xen/include/asm-x86/edd.h         |    6 --
> >  xen/include/asm-x86/mbd.h         |   80 ++++++++++++++++++
> >  xen/include/asm-x86/setup.h       |   12 +--
> >  xen/include/xen/efi.h             |    7 ++
> >  xen/include/xen/multiboot2.h      |  153 ++++++++++++++++++++++++++++++++++
> >  xen/include/xen/vga.h             |   18 ----
> >  xen/include/xsm/xsm.h             |   16 ++--
> >  xen/xsm/xsm_core.c                |    6 +-
> >  xen/xsm/xsm_policy.c              |   10 +--
> >  35 files changed, 1344 insertions(+), 534 deletions(-)
>
> already makes clear that is isn't the right time for this to get merged,

OK.

> leaving aside my reservations against you touching all this early boot

What is your main concern here (beside that it is big patch series)?

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel