Re: [Xen-devel] [PATCH v3 for 4.5] x86/viridian: Freeze time reference counter when domain is paused

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.10.14 at 11:21, <paul.durrant@xxxxxxxxxx> wrote:
> v3:
>  - Moved viridian calls into new arch_domain functions as suggested by Jan

Much better this way imo, but sadly ...

> --- a/xen/arch/arm/domain.c
> +++ b/xen/arch/arm/domain.c
> @@ -580,6 +580,18 @@ void arch_domain_destroy(struct domain *d)
>      free_xenheap_page(d->shared_info);
>  }
>  
> +void arch_domain_shutdown(struct domain *d)
> +{
> +}
> +
> +void arch_domain_pause(struct domain *d)
> +{
> +}
> +
> +void arch_domain_unpause(struct domain *d)
> +{
> +}
> +

... you forgot to Cc the ARM maintainers (doing so now) - one of
them will need to ack this addition.

> @@ -925,32 +927,36 @@ int vcpu_unpause_by_systemcontroller(struct vcpu *v)
>      return 0;
>  }
>  
> -void domain_pause(struct domain *d)
> +void do_domain_pause(struct domain *d,
> +                     void (*sleep_fn)(struct vcpu *v))

Already for v3 I pointed out that this could (and should) be static.
I've taken note of this and the whitespace issue Andrew pointed
out in case this can be committed without another full round.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel