[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 5/8] xen/x86: introduce more cache maintenance operations



>>> On 13.10.14 at 16:58, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> Move the existing flush_page_to_ram flushtlb.h.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
provided you ...

> +static inline int clean_and_invalidate_dcache_va_range(const void *p, 
> unsigned long size)
> +{
> +    unsigned int order = get_order_from_bytes(size);
> +    /* sub-page granularity support needs to be added if necessary */
> +    flush_area_local(p, FLUSH_CACHE|FLUSH_ORDER(order));
> +    return 0;
> +}
> +static inline int clean_dcache_va_range(const void *p, unsigned long size)
> +{
> +    clean_and_invalidate_dcache_va_range(p, size);
> +    return 0;

... either make this return the called function's return value or make
the whole thing a simple, object-like macro.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.