Re: [Xen-devel] [PATCH v2 for 4.5] arm32: fix build after 063188f4b3

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Mon, 2014-10-13 at 16:29 +0100, Julien Grall wrote:

> +GLOBAL(do_smc)

> +GLOBAL(do_smc)

These should both be ENTRY.

> +int do_smc(register_t function_id, ...);

Are you sure that the variadic function calling convention is the same
as for a regular function call? I'm not entirely clear having read
AAPCS, it says they are marshalled according to "the standard base". 

I think it would probably be safer to declare this guy as taking 3-4
arguments and pass in 0 for the unused one. You could wrap in
do_smc<N>() helpers if you really wanted.

I'd prefer to name this call_smc, do_foo tends to be used on the callee
side of exception things (e.g. do_hypervisor_trap etc, do_psci_blah).

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel