Re: [Xen-devel] [PATCH for-xen-4.5 v3 03/16] x86/boot/reloc: Create generic alloc and copy functions

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 13/10/14 16:00, Daniel Kiper wrote:
> On Thu, Oct 09, 2014 at 10:45:08AM +0100, Andrew Cooper wrote:
>> On 08/10/14 18:52, Daniel Kiper wrote:
>>> Create generic alloc and copy functions. We need them to
>>> introduce MBD struct and multiboot2 protocol. Please
>>> check later patches for more details.
>>>
>>> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
>> copy_string() is fine, as all its uses are in terms of u32s, but why do
>> the other two change from pointers to u32s now?
>>
>> You could drop almost all of the casts with the reintroduction of the
>> void pointers.  This code, after all, is only ever going to be 32bit.
> We need some casts in this patch but after moving to MBD there are not any 
> casts.
>
> Daniel

Ok - that is a good reason.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel