Re: [Xen-devel] [PATCH v4 4/7] xen/x86: introduce more cache maintenance operations

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 13 Oct 2014, Jan Beulich wrote:
> >>> On 13.10.14 at 12:35, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > On Fri, 10 Oct 2014, Jan Beulich wrote:
> >> >>> On 10.10.14 at 13:43, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> >> > +void clean_and_invalidate_dcache_va_range(const void *p, unsigned long 
> >> > size)
> >> > +{
> >> > +    int order = get_order_from_bytes(size);
> >> 
> >> unsigned int if the variable is really needed.
> >> 
> >> > +    flush_area_local(p, FLUSH_CACHE|FLUSH_ORDER(order));
> >> > +}
> >> 
> >> Overall I wonder whether not making this an inline function is really
> >> appropriate.
> > 
> > Introducing this function as static inline in page.h would cause the
> > number of included files to grow a bit too much I think.
> 
> Or maybe page.h is simply the wrong home for them, at least on
> x86?

good point, I'll move them to flushtlb.h

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel