Re: [Xen-devel] [OSSTEST PATCH v2 05/12] mfi-common: create build-$arch-xsm job

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Oct 10, 2014 at 04:32:36PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[OSSTEST PATCH v2 05/12] mfi-common: create build-$arch-xsm 
> job"):
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > +    for xsm in $test_xsm; do
> > +      if [ x$xsm = xy ] ; then
> > +        xsm_suffix="-xsm"
> > +        enable_xsm=y
> > +      else
> > +        xsm_suffix=""
> > +        enable_xsm=n
> > +      fi
> 
> Why not
>    for enable_xsm in ...
> and do away with one of the variables ?
> 
> And that if would probably be clearer as a case.
> 

No problem.

Wei

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel