Re: [Xen-devel] [PATCH] tools/hotplug/Linux: Fix build

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, Oct 10, 2014 at 11:59:08AM +0200, Olaf Hering wrote:
> On Fri, Oct 10, Ian Campbell wrote:
> 
> > I expect the actual problem is that the buildsystem is recusing into
> > this directory twice simultaneously for "all" and "install" at the same
> > time. That seems likely to be an issue with the Makefile in the parent
> > directory.
> > 
> > Should subdirs-install depend on subdirs-all perhaps?
> 
> Anthony, how do you invoke make? While I have seen it often right now
> I'm unable to reproduce. There are never 'all' and 'install' targets in
> the log. I think my script always called make rpmball.

There are a lot of things in my build script, but it should be done to
this:
git clone
./configure --enable-systemd --other-stuff
export MAKEFLAGS="-j24"
edit .config to use local git tree
make

And later in the process, a `make install` is called but the faillure
is before that.

> I think only the install rule should depend on ALL_XEN_SYSTEMD because
> in the end thats the only place that matters. There is nothing to build,
> and the single xen.conf file could also be generated on the fly during
> install.
>
> But still it would be nice to know what the root cause is.

It look like hotplug stuff are done like that:
make[2]: Entering directory '/build/xen-unstable/src/xen-unstable/tools'
make -C hotplug install

then calling make install on other subdir.
And after entering tools/Linux, I can see both rules "all" and
"install" been called on systemd directory (unfortunatly, at the same
time on this machine).


I think the problem is in tools/Linux/Makefile, where we have:
all: subdirs-all
install: all subdirs-install

Maybe the "install" rules should depend only on the things it need to
install, and not an "all".

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel