Re: [Xen-devel] [PATCH for-xen-4.5 v3 02/16] x86/boot/reloc: Move typedef and include to beginning of file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.10.14 at 19:52, <daniel.kiper@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/boot/reloc.c
> +++ b/xen/arch/x86/boot/reloc.c
> @@ -10,6 +10,10 @@
>   *    Keir Fraser <keir@xxxxxxx>
>   */
>  
> +typedef unsigned int u32;
> +
> +#include "../../../include/xen/multiboot.h"
> +
>  /* entered with %eax = BOOT_TRAMPOLINE */
>  asm (
>      "    .text                         \n"
> @@ -30,9 +34,6 @@ asm (
>      "    .long 0                       \n"
>      );
>  
> -typedef unsigned int u32;
> -#include "../../../include/xen/multiboot.h"
> -
>  static void *reloc_mbi_struct(void *old, unsigned int bytes)
>  {
>      void *new;

In an earlier version you added some shouting warning comments to
point out where the entry point here is. Without your adjustment it
was right at the top of the file, making it rather obvious. I don't see
what the adjustment you do here is good for, and you also don't
say so (description is missing altogether).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel