Re: [Xen-devel] [PATCH v2] Separate runtime debug output from debug symbols

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-10-06 at 10:03 +0100, Jan Beulich wrote:
> >>> On 06.10.14 at 10:55, <olaf@xxxxxxxxx> wrote:
> > Two make variables exist (debug=y and debug_symbols=y) to control either
> > the creation of additional runtime debug or the creation of debug
> > symbols for tools like gdb.  Some places in the code still passed -g
> > unconditionally to the compiler. Wrap them into a "debug_symbols"
> > conditional. The xen build passed -g unconditional, reuse the existing
> > debug_symbols=y check in Config.mk. There are still parts of the code
> > that hardcode -g, namely the external qemu-traditional and stubdom
> > packages. They are not changed by this patch.
> > 
> > No change in behaviour is expected by that patch for tools and xen.
> > For stubdom CFLAGS change from -O1 to O2 with debug=n.
> > 
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> >[...]
> >  xen/Rules.mk            | 2 +-
> 
> For just this small part of the patch:
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Unfortunately this seems to cause:

        /usr/bin/wget -c -O zlib-1.2.3.tar.gz /zlib-1.2.3.tar.gz
        /zlib-1.2.3.tar.gz: Scheme missing.

I think the reordering in stubdom/Makefile has caused XEN_EXTFILES_URL
to not be defined at the correct point in time.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel