Re: [Xen-devel] [PATCH v2] xen/balloon: Don't continue ballooning when BP_ECANCELED is encountered

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Tue, Oct 07, 2014 at 05:00:07PM -0400, Boris Ostrovsky wrote:
> Commit 3dcf63677d4e ("xen/balloon: cancel ballooning if adding new
> memory failed") makes reserve_additional_memory() return BP_ECANCELED
> when an error is encountered. This error, however, is ignored by the
> caller (balloon_process()) since it is overwritten by subsequent call
> to update_schedule(). This results in continuous attempts to add more
> memory, all of which are likely to fail again.
>
> We should stop trying to schedule next iteration of ballooning when
> the current one has failed.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> ---
> v2: Move status test to update_schedule()
>
>  drivers/xen/balloon.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 1e0a317..3860d02 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -167,6 +167,9 @@ static struct page *balloon_next_page(struct page *page)
>
>  static enum bp_state update_schedule(enum bp_state state)
>  {
> +     if (state == BP_ECANCELED)
> +             return BP_ECANCELED;
> +
>       if (state == BP_DONE) {
>               balloon_stats.schedule_delay = 1;
>               balloon_stats.retry_count = 1;

Thanks. Please next time send Linux Kernel patches to LKML too.
Cc-ing it just in case.

Reviewed-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel