Re: [Xen-devel] [PATCH v18 08/10] x86: add CMT related MSRs in allowed list

[Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>]

On Tue, Sep 30, 2014 at 02:26:35PM +0100, Jan Beulich wrote:
> >>> On 30.09.14 at 12:49, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> > --- a/xen/include/asm-x86/msr-index.h
> > +++ b/xen/include/asm-x86/msr-index.h
> > @@ -324,6 +324,8 @@
> >  #define MSR_IA32_ENERGY_PERF_BIAS  0x000001b0
> >  

We discussed this internally and finally we decide to continue to use
the names in current SDM. Which is slightly different with what we used
here and also different with what you suggested here.

It looks still a little confusing but these MSRs maybe used in features
than just CMT so narrowing down to CMT is not OK.

I will fix this in a new version and let you know.
Thanks,
Chao

> >  /* Platform Shared Resource MSRs */
> > +#define MSR_IA32_QOSEVTSEL         0x00000c8d
Will be MSR_IA32_QM_EVTSEL
> 
> Is this still an appropriate name with then name change "QOS" -> "CMT"?
> 
> > +#define MSR_IA32_QMC                       0x00000c8e
Will be MSR_IA32_QM_CTR
> 
> The Q here may similarly be questionable now.
> 
> >  #define MSR_IA32_PQR_ASSOC         0x00000c8f
Stay unchange.
> 
> And maybe even the one here?
> 
> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel