Re: [Xen-devel] [PATCH 02/28] tools/hotplug: fix race during xen.conf creation

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Wed, Oct 01, 2014 at 06:41:04PM +0200, Olaf Hering wrote:
> A make -j8 will call the xen.conf rule twice. The move-if-changed
> macro may fail of the tmp file was already removed by the other make

s/of/if/
> process. Fix this by let the all target depend on install.
> Also remove the generated file with make clean.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  tools/hotplug/Linux/systemd/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/hotplug/Linux/systemd/Makefile 
> b/tools/hotplug/Linux/systemd/Makefile
> index dc98b67..90ba16e 100644
> --- a/tools/hotplug/Linux/systemd/Makefile
> +++ b/tools/hotplug/Linux/systemd/Makefile
> @@ -21,10 +21,11 @@ ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES)  \
>                       $(XEN_SYSTEMD_SERVICE)
>  
>  .PHONY: all
> -all: $(ALL_XEN_SYSTEMD)
> +all: install
>  
>  .PHONY: clean
>  clean:
> +     rm -f $(ALL_XEN_SYSTEMD)
>  
>  .PHONY: install
>  install: $(ALL_XEN_SYSTEMD)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel