[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v19 00/10] enable Cache Monitoring Technology (CMT) feature

On Thu, Oct 02, 2014 at 03:33:50PM +0100, Jan Beulich wrote:
> >>> On 02.10.14 at 13:35, <chao.p.peng@xxxxxxxxxxxxxxx> wrote:
> > Chao Peng (10):
> >   x86: add generic resource (e.g. MSR) access hypercall
> >   xsm: add resource operation related xsm policy
> >   tools: provide interface for generic resource access
> >   x86: detect and initialize Cache Monitoring Technology feature
> >   x86: dynamically attach/detach CMT service for a guest
> >   x86: collect global CMT information
> >   x86: enable CMT for each domain RMID
> >   x86: add CMT related MSRs in allowed list
> >   xsm: add CMT related xsm policies
> >   tools: CMDs and APIs for Cache Monitoring Technology
> So apart from patch 10 this series can now be considered
> sufficiently acked to go in. Which means - Konrad, you'll now have
> to decide whether it still should (possibly including whether to wait
> for patch 10 to get acked).

I believe it is OK to add this in as:

 - It is a new functionality that will only be used if the system admin
   uses the bootup parameters. Hence existing users / use-cases will not be 

 - The common code that is used to "glue" the CMT with this is quite simple.

 - The two new sets of hypercalls are safe and look to not cause DoS nor inflict
   damage to the hypervisor. They also have XSM labels.

 - The risk of regression in normal existing use-case is minimal.

I am OK with patch #10 going in after getting an Ack/Reviewed-by from
one of the tools maintainers. Since that is not right now happening it can
be done later (but before RC0). Or if it misses RC0 then it would have to be
done in Xen 4.6.

So Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> all patches
except #10.

> Jan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.