Re: [Xen-devel] [PATCH] x86: favor function parameter over global in construct_dom0()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.10.14 at 17:11, <konrad.wilk@xxxxxxxxxx> wrote:
> On Thu, Oct 02, 2014 at 02:36:41PM +0100, Jan Beulich wrote:
>> There's no reason to use the "hardware_domain" variable anywhere here,
>> making the code more cumbersome to read.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> 
>> --- a/xen/arch/x86/domain_build.c
>> +++ b/xen/arch/x86/domain_build.c
>> @@ -270,7 +270,7 @@ static unsigned long __init compute_dom0
>>      return nr_pages;
>>  }
>>  
>> -static void __init process_dom0_ioports_disable(void)
>> +static void __init process_dom0_ioports_disable(struct domain *dom0)
> 
> Why not make that also 'd' ?

Because of the function name, matching style with alloc_dom0_vcpu0().

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel