Re: [Xen-devel] [PATCH 1/2] xen/arm: Initial support for PSCI-0.2

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-10-01 at 15:02 -0500, suravee.suthikulpanit@xxxxxxx wrote:
> -int __init psci_init(void)
> +void call_psci_system_off(void)
> +{
> +    if ( psci_ver > 2 )

Doesn't this need to be >= to do anything on a 0.2 system? (Likewise in
the fn below)

> +        __invoke_psci_fn_smc(PSCI_0_2_FN_SYSTEM_OFF, 0, 0, 0);

Should we print a message in the case that we aren't able to call the
0.2 handler? (again, likewise below)

> +}

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel