Re: [Xen-devel] [PATCH 3/4] xen/arm: Add PSCI system_off and system_reset support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-10-01 at 11:07 +0100, Stefano Stabellini wrote:
> > diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c
> > index adc0529..2f63674 100644
> > --- a/xen/arch/arm/shutdown.c
> > +++ b/xen/arch/arm/shutdown.c
> > @@ -6,11 +6,6 @@
> >  #include <xen/smp.h>
> >  #include <asm/platform.h>
> >  
> > -static void raw_machine_reset(void)
> > -{
> > -    platform_reset();
> > -}
> 
> Please mention this change in the commit message.

Actually, since this is going to need a freeze exception I think it
would be good to split into individual commits which separately:
        Refactor raw_machine_reset
        (Re)Implement machine_halt
        Introduce whatever PSCI stuff is needed.

That'll make it easier to reason about and make an argument for.

BTW I'm in favour of trying to get this stuff in for 4.5.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel