Re: [Xen-devel] [PATCH ARM v7 09/13] mini-os: arm: time

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-10-01 at 12:10 +0100, Thomas Leonard wrote:
> On 22 September 2014 11:35, Dave Scott <Dave.Scott@xxxxxxxxxx> wrote:
> > Hi,
> >
> > On 8 Sep 2014, at 17:08, Thomas Leonard <talex5@xxxxxxxxx> wrote:
> >
> >> On 8 September 2014 11:59, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> >>> On Fri, 2014-08-08 at 16:47 +0100, Thomas Leonard wrote:
> >>>
> >>> Sorry for how long I took to get to this, travel and the resulting
> >>> backlog conspired against me.
> [...]
> >>>> +void block_domain(s_time_t until)
> >>>> +{
> >>>> +    uint64_t until_count = ns_to_ticks(until) + cntvct_at_init;
> >>>> +    ASSERT(irqs_disabled());
> >>>> +    if (read_virtual_count() < until_count)
> >>>> +    {
> >>>> +        set_vtimer_compare(until_count);
> >>>> +        //char buf[] = "sleep\n"; 
> >>>> (void)HYPERVISOR_console_io(CONSOLEIO_write, strlen(buf), buf);
> >>>> +        __asm__ __volatile__("wfi");
> >>>> +        //char wake[] = "wake\n"; 
> >>>> (void)HYPERVISOR_console_io(CONSOLEIO_write, strlen(wake), wake);
> >>>
> >>> More left over debug.
> [...]
> > I had a play with this yesterday on my cubieboard with Mirage. Using 
> > network and vchan connections worked fine, so event channels are working 
> > ok. However when I had no external event channel input and my domain 
> > blocked on a timer, it seemed to block forever in the âwfiâ (as I could see 
> > by enabling these debug lines and then pressing âenterâ to trigger an 
> > interrupt on the console).
> 
> [...]
> 
> Given that at least one person has already made use of these debug
> lines, perhaps I should leave them in?

If they are to stay they need to be done with a proper ifdef controlled
debug option (perhaps a DPRINT macro, not inline #ifdefs), commented out
as you have it isn't ok.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel