[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 01/28] Neutralize make uninstall

On Tue, Sep 30, Olaf Hering wrote:

> On Mon, Sep 29, Ian Campbell wrote:
> > Yet? Will this be replaced by additions to the appropriate submake files
> > in the course of this series?
> No. Unless I miss something, make uninstall can not work today. At least
> for the toplevel Makefile. If you want I can add more uninstall parts to
> the tools Makefiles in a separate series. Either for 4.5 or later.


now that I look at staging-4.4 I see that the toplevel Makefile includes
config/StdGNU.mk which sets path variables used by the uninstall target.
So my series broke uninstall because the variables are not available
anymore during 'make uninstall'. I think the right fix is to move the
uninstall target to the invividual Makefiles in tools/hotplug/.
XEN_RUN_DIR is created at runtime now, it should be left alone by
uninstall. /var/lib/xen is created in tools/Makefile, so it should be
removed there.

I will adjust this patch and include it in v5 of this series.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.