Re: [Xen-devel] [PATCH 20/28] Put bash_completion.d below --sysconfdir=DIR

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-25 at 17:20 +0200, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Not sure the subject is 100% accurate, since it seems to just be moving
the location of the definition, not changing it in any way?

> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  Config.mk          | 2 --
>  config/Paths.mk.in | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index 73281d8..cf7af12 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -58,8 +58,6 @@ endif
>  include $(XEN_ROOT)/config/$(XEN_OS).mk
>  include $(XEN_ROOT)/config/$(XEN_TARGET_ARCH).mk
>  
> -BASH_COMPLETION_DIR ?= $(CONFIG_DIR)/bash_completion.d
> -
>  # arguments: variable, common path part, path to test, if yes, if no
>  define setvar_dir
>    ifndef $(1)
> diff --git a/config/Paths.mk.in b/config/Paths.mk.in
> index 8755785..e1fe4a3 100644
> --- a/config/Paths.mk.in
> +++ b/config/Paths.mk.in
> @@ -50,6 +50,7 @@ XEN_LIB_STORED           := @XEN_LIB_STORED@
>  
>  CONFIG_DIR               := @CONFIG_DIR@
>  INITD_DIR                := @INITD_DIR@
> +BASH_COMPLETION_DIR      := $(CONFIG_DIR)/bash_completion.d
>  XEN_LOCK_DIR             := @XEN_LOCK_DIR@
>  XEN_PAGING_DIR           := @XEN_PAGING_DIR@
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel