Re: [Xen-devel] [PATCH 11/28] tools: substitute bindir instead of BINDIR

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-25 at 17:20 +0200, Olaf Hering wrote:
> ... and same for sbindir and libdir.
> Expand usage of exec_prefix so that it does not appear in substituted
> variables in systemd files.
> 
> Please rerun autogen.sh after applying this patch.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  config/Paths.mk.in                                  |  6 +++---
>  m4/paths.m4                                         | 15 +++++----------
>  m4/xenstored.m4                                     |  8 ++++----
>  tools/hotplug/Linux/init.d/sysconfig.xencommons.in  |  4 ++--
>  tools/hotplug/Linux/systemd/xen-watchdog.service.in |  2 +-
>  tools/hotplug/Linux/systemd/xenconsoled.service.in  |  2 +-
>  tools/hotplug/Linux/systemd/xenstored.service.in    |  4 ++--
>  7 files changed, 18 insertions(+), 23 deletions(-)
> 
> diff --git a/config/Paths.mk.in b/config/Paths.mk.in
> index 65ca37b..c3c9897 100644
> --- a/config/Paths.mk.in
> +++ b/config/Paths.mk.in
> @@ -29,12 +29,12 @@ includedir               := @includedir@
>  localstatedir            := @localstatedir@
>  sysconfdir               := @sysconfdir@
>  
> -SBINDIR                  := @SBINDIR@
> -BINDIR                   := @BINDIR@
> +SBINDIR                  := $(sbindir)
> +BINDIR                   := $(bindir)

You switch all the users of these to the lower case version, don't you?
Or only partially perhaps?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel